Add JRuby examples in rules_advanced.md #2451
Open
+228
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
jimtng
force-pushed
the
rules-advanced-ruby
branch
2 times, most recently
from
19d2da0 to
5129079
Compare
ccutrer
reviewed
Jan 18, 2025
|
Oops I missed those three remaining comments/change requests. Changes have now been made to address them. |
|
ping @ccutrer |
ccutrer
reviewed
Apr 12, 2025
| logger.info "Motion was detected" | ||
| FrontPorchLight.on | ||
|
|
||
| after 30.minutes, id: FrontPorchLight do |timer| |
There was a problem hiding this comment.
It's not entirely obvious from the narrative above that if this rule is executed multiple times, because the timer has an id, it will find that timer and reschedule it, rather than starting a new timer that happens to have the same ID.
There was a problem hiding this comment.
I've added additional sentences which could use some further review
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
jimtng
force-pushed
the
rules-advanced-ruby
branch
from
b634cfa to
98324ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.