Fix SSE topic filters

[J-N-K]

Fixes #2473

According to the documentation, topic filters are regular expressions. The SSE topic filters are converted to regular expressions, therefore openhab/items/*/state should result in openhab/items/.*/state. The code however adds a .* at the end openhab/items/.*/state.*. This makes it impossible to filter for /state but exclude /statechanged, which is IMO expected.

Signed-off-by: Jan N. Klug github@klug.nrw

[ghys]

Please hold on merging this as the UI is probably making requests that assume the current syntax, so the impact has to be assessed.

[J-N-K]

According to the list you showed in the linked issue everything should be fine, since proper matching is done for all things, items, rules and addons (* at the end or where a wildcard should be used).

You would only be affected if you subscribed to openhab/items (without *) and expected a subscription for all topics starting with openhab/items. As long as a * is at the end of the filter, nothing changes.

[wborn]

LGTM! Did you already have a look @ghys?

[ghys]

Yes sorry I agree with @J-N-K's assessment! My earlier remark was just out of an abundance of caution, but it turns out it's fine.

[lolodomo]

@J-N-K : does this change break my event subscription?
https://github.com/openhab/openhab-addons/blob/main/bundles/org.openhab.binding.remoteopenhab/src/main/java/org/openhab/binding/remoteopenhab/internal/rest/RemoteopenhabRestClient.java#L333

[J-N-K]

No, it‘ll only break if your subscription does not end with * AND you rely on an implicitly added * at the end (your subscription ends with state instead of state* but you expect to also cover statechanged).

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-3-3-release-discussion/136925/71

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/problems-subscribing-to-events-in-habapp/137124/6

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/habapp-1-0-beta-test/136952/25