Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes docker-compose, adds HTTPS and refactors image builds (fixes #234) #276

Merged
merged 5 commits into from
Jan 16, 2020
Merged

Fixes docker-compose, adds HTTPS and refactors image builds (fixes #234) #276

merged 5 commits into from
Jan 16, 2020

Conversation

alackmann
Copy link
Contributor

@alackmann alackmann commented Aug 24, 2019 •
edited
Loading

  • Fixes failing docker-compose file with new images and linking
  • Replaces nginx http proxy with traefik with LetsEncrypt SSL certs which is just better
  • Assumes a move to remote managed builds (requiring some setup on the official repo to work properly), rather than build on device. This allows easier remote deployment without the full repository. The assumption being, most people who want to deploy their own OpenHAB Cloud are doing so on a server of some sort, rather than their personal device and don't want to muck about with a local build every time they make a change to the configuration. This method allows configuration to be separated from the app code.

Let me know if I've broken anything. Comments welcome..

@alackmann
Feature/automate docker build (#4)
85e7dc2 
* Moved Dockerfile into root

* Dockerfile tidying

Signed-off-by: Andre Lackmann <andre@lackmann.net>
@alackmann
Feature/docker compose update (#5)
63a5b0a 
* Moved Dockerfile into root
* Dockerfile tidying
* moving and updating docker-compose
* updated docker configuration and docs

Signed-off-by: Andre Lackmann <andre@lackmann.net>
@alackmann alackmann changed the title Fixes docker-compose, adds HTTPS and refactors image builds (#234) Fixes docker-compose, adds HTTPS and refactors image builds (fixes #234) Aug 24, 2019
@alackmann
Copy link
Contributor Author

Proposed fix for #234

@alackmann
Updated docker-compose to use official image tag
97fa517 
Signed-off-by: Andre Lackmann <andre@lackmann.net>
@alackmann
updated logging to work in docker using console
0e89f1c 
Signed-off-by: Andre Lackmann <andre@lackmann.net>
@alackmann
Merge pull request #7 from alackmann/feature/fix-logging-in-docker
4f150a5 
Feature/fix logging in docker
@alackmann
Copy link
Contributor Author

Also included a fix for #278 here (0e89f1c) - as without it, the current images don't use the new logging code anyway.

@alackmann alackmann mentioned this pull request Aug 26, 2019
Closed
@alackmann alackmann mentioned this pull request Oct 13, 2019
Closed
@digitaldan digitaldan merged commit 56c6c78 into openhab:master Jan 16, 2020
@jasonxh jasonxh mentioned this pull request Mar 8, 2020
Merged
@cniweb cniweb mentioned this pull request Jan 10, 2023
Open
@cniweb cniweb mentioned this pull request Feb 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alackmann @digitaldan