Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nuvo] Set autoUpdatePolicy for WriteOnly channels #17465

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[nuvo] Set autoUpdatePolicy for WriteOnly channels #17465

merged 1 commit into from
Sep 24, 2024

Conversation

mlobstein
Copy link
Contributor

Replaces #17439
Set autoUpdatePolicy=veto for WriteOnly channels

@mlobstein
Set autoUpdatePolicy for WriteOnly channels
dba16b3 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein mlobstein added the enhancement An enhancement or new feature for an existing add-on label Sep 23, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Sep 23, 2024

Was about to merge this and had some doubts if update instructions would be needed for managed things. The documentation does not explicit mention if the autoupdatepolicy requires instructions. Did you test if the policy is updated without instructions for managed things?

@mlobstein
Copy link
Contributor Author

Was about to merge this and had some doubts if update instructions would be needed for managed things. The documentation does not explicit mention if the autoupdatepolicy requires instructions. Did you test if the policy is updated without instructions for managed things?

I have not tested. However, I saw several other PRs recently like #17411 that did not have instructions.

@kaikreuzer
Copy link
Member

I guess even if managed things are not updated, it is ok to keep them as they are - this makes the change even less intrusive.

@kaikreuzer kaikreuzer merged commit 17b8f0d into openhab:main Sep 24, 2024
5 checks passed
@kaikreuzer kaikreuzer added this to the 4.3 milestone Sep 24, 2024
@mlobstein mlobstein deleted the autoupdate_nuvo branch September 24, 2024 13:32
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@mlobstein @joni1993
Set autoUpdatePolicy for WriteOnly channels (openhab#17465)
1d93015 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@mlobstein @matchews
Set autoUpdatePolicy for WriteOnly channels (openhab#17465)
1b46fd5 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mlobstein @lsiepel @kaikreuzer