Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script to create new binding skeleton: problem with file bundles/pom.xml #13405

Open
lolodomo opened this issue Sep 18, 2022 · 7 comments
Open

Script to create new binding skeleton: problem with file bundles/pom.xml #13405

lolodomo opened this issue Sep 18, 2022 · 7 comments
Labels
external bug A problem or unintended behavior of an external library

Comments

@lolodomo
Copy link
Contributor

lolodomo commented Sep 18, 2022 •
edited
Loading

The script to create a new binding skeleton is generating a lot of changes in the file bundles/pom.xml. Only one line should be added (for the new binding) but in fact it generates a lot of more changes, certainly for formatting reason.

Tested with the Windows bat command file.
@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Sep 18, 2022
@wborn
Copy link
Member

wborn commented Sep 19, 2022

Do you really mean bom/pom.xml or those new lines that are added to bundles/pom.xml?

@lolodomo
Copy link
Contributor Author

You,'re right, it is bundles/pom.xml. I correct issue title and description,

@lolodomo lolodomo changed the title Script to create new binding skeleton: problem with file bom/pom.xml Script to create new binding skeleton: problem with file bundles/pom.xml Sep 19, 2022
@lolodomo
Copy link
Contributor Author

lolodomo commented Sep 19, 2022 •
edited
Loading

Look at current PR #13400 for an example.

wborn added a commit to wborn/openhab-addons that referenced this issue Sep 19, 2022
@wborn
Prevent new lines in bundles/pom.xml when creating binding skeleton
eb196cd 
Downgrades the Maven archetype plugin as workaround for:

* https://issues.apache.org/jira/browse/ARCHETYPE-584
* https://issues.apache.org/jira/browse/ARCHETYPE-587

Fixes openhab#13405

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn mentioned this issue Sep 19, 2022
Closed
@wborn
Copy link
Member

wborn commented Sep 19, 2022

Look at PR #13418 for a workaround. 😉

@jannegpriv jannegpriv mentioned this issue Sep 19, 2022
Merged
@wborn wborn mentioned this issue Oct 9, 2022
Merged
@wborn wborn added external bug A problem or unintended behavior of an external library and removed bug An unexpected problem or unintended behavior of an add-on labels Nov 5, 2022
@wborn
Copy link
Member

wborn commented Nov 5, 2022 •
edited
Loading

This will be fixed when the following issues are fixed in the Maven archetype plugin:

@wborn wborn mentioned this issue Apr 16, 2023
Merged
@wborn
Copy link
Member

wborn commented Oct 24, 2024

Is this still an issue for you @lolodomo now that ARCHETYPE-637 got fixed in 3.3.0 of the maven-archetype-plugin?
The scripts don't specify a version so they use the latest version.

@lolodomo
Copy link
Contributor Author

I can try during the coming weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external bug A problem or unintended behavior of an external library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent new lines in bundles/pom.xml when creating binding skeleton wborn/openhab-addons
2 participants
@lolodomo @wborn