bump @opengovsg/starter-kitty-validators to 1.2.7 #874
+28
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adriangohjw
had a problem deploying
to
staging
GitHub Actions
Failure
Datadog ReportBranch report: ✅ 0 Failed, 180 Passed, 34 Skipped, 38.87s Total Time |
adriangohjw
had a problem deploying
to
staging
GitHub Actions
Failure
harishv7
reviewed
Nov 12, 2024
| @@ -25,6 +26,16 @@ const config: StorybookConfig = { | |||
| disableTelemetry: true, | |||
| }, | |||
|
|
|||
| // https://github.com/vercel/next.js/issues/28774#issuecomment-1264555395 | |||
There was a problem hiding this comment.
are these changes related to the version bump?
| @@ -65,6 +67,15 @@ const config = { | |||
| images: { | |||
| domains: [env.NEXT_PUBLIC_S3_ASSETS_DOMAIN_NAME ?? ""].filter((d) => d), | |||
| }, | |||
| // https://github.com/vercel/next.js/issues/28774#issuecomment-1264555395 | |||
There was a problem hiding this comment.
saw the linked issue, why did this occur suddenly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
re: https://opengovproducts.slack.com/archives/CK68JNFHR/p1730972525340969
Solution
Breaking Changes
Yes - this PR contains breaking changes
No - this PR is backwards compatible
pump dependencies in package.json and package-lock.json
polyfill unsupported
node:pathfor webpack in nextjs and storybookNew dependencies:
@opengovsg/starter-kitty-validators: bumped to 1.2.7