-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dependabot yml #873
Fix dependabot yml #873
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Datadog ReportBranch report: ✅ 0 Failed, 180 Passed, 34 Skipped, 36.88s Total Time |
@@ -4,6 +4,8 @@ updates: | |||
directory: "/" | |||
schedule: | |||
interval: daily | |||
versioning-strategy: increase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually both of these keys are not required according to the docs. Just curious why adding this 2 fixes the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im not exactly sure but i was wondering why the bot isn't triggering and seems like someone else had the same issue and was fixed by adding versioning-strategy
(dependabot/dependabot-core#5226) so I thought I'd give it a try
the other one open-pull-requests-limit
had nothing to do with the issue but a good to have, to increase the limit from the default 5 to 10. Once the limit is hit, it stopped opening a new PR and from experience it's very easy to hit the default 5 limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright
@@ -4,6 +4,8 @@ updates: | |||
directory: "/" | |||
schedule: | |||
interval: daily | |||
versioning-strategy: increase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright
Problem
Currently dependabot isn't working. for example, there's a new version in
@opengovsg/starter-kitty-validators
but it's not automatically bumpedSolution
Breaking Changes
Improvements:
open-pull-requests-limit
to 10 (default 5)Bug Fixes:
versioning-strategy: increase
according to Dependabot not bumping dependencies in npm workspaces / monorepo structure dependabot/dependabot-core#5226 as this seems to be due to us using monorepo npm workspaces