Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependabot yml #873

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Fix dependabot yml #873

merged 2 commits into from
Nov 12, 2024

Conversation

adriangohjw
Copy link
Contributor

Problem

Currently dependabot isn't working. for example, there's a new version in @opengovsg/starter-kitty-validators but it's not automatically bumped

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

Improvements:

  • increase open-pull-requests-limit to 10 (default 5)

Bug Fixes:

@adriangohjw adriangohjw added the bug Something isn't working label Nov 12, 2024
@adriangohjw adriangohjw self-assigned this Nov 12, 2024
@adriangohjw adriangohjw requested a review from a team as a code owner November 12, 2024 11:52
Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
isomer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 11:54am

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Nov 12, 2024

Datadog Report

Branch report: fix-dependabot-yml
Commit report: f722594
Test service: isomer-studio

✅ 0 Failed, 180 Passed, 34 Skipped, 36.88s Total Time
➡️ Test Sessions change in coverage: 1 no change

@@ -4,6 +4,8 @@ updates:
directory: "/"
schedule:
interval: daily
versioning-strategy: increase
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually both of these keys are not required according to the docs. Just curious why adding this 2 fixes the issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not exactly sure but i was wondering why the bot isn't triggering and seems like someone else had the same issue and was fixed by adding versioning-strategy (dependabot/dependabot-core#5226) so I thought I'd give it a try

the other one open-pull-requests-limit had nothing to do with the issue but a good to have, to increase the limit from the default 5 to 10. Once the limit is hit, it stopped opening a new PR and from experience it's very easy to hit the default 5 limit

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright

@@ -4,6 +4,8 @@ updates:
directory: "/"
schedule:
interval: daily
versioning-strategy: increase
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright

@adriangohjw adriangohjw merged commit d325f12 into main Nov 12, 2024
16 checks passed
@adriangohjw adriangohjw deleted the fix-dependabot-yml branch November 12, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants