isom-1655 display block contents for identification #867
Conversation
…display-block-contents-for-identification
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Datadog ReportBranch report: ✅ 0 Failed, 175 Passed, 34 Skipped, 37.27s Total Time 🔻 Code Coverage Decreases vs Default Branch (1)
|
There was a problem hiding this comment.
just abit confused - why are we adding this here when the dependency is in studio?
There was a problem hiding this comment.
yeah i think it's a tough greyline as the initial implementation is to have it in studio
but had a discussion with @dcshzj and decided that studio shouldn't have to know what's going on in the Component library. Plus when we add new component on the Component library, we will also be less likely to forget about it
| function getTextContentOfProse(content: ProseContent): string { | ||
| const values: string[] = [] | ||
|
|
||
| function recursiveSearch(obj: Record<string, unknown>) { |
There was a problem hiding this comment.
i haven't tried it yet, but editor.getText (see here) seems ideal for this - should we do it on studio since this appears to be studio specific?
There was a problem hiding this comment.
we aren't using the tiptap editor for this part yet
There was a problem hiding this comment.
nono, i mean since this part comes from tiptap, we can shift this over to tiptap
There was a problem hiding this comment.
oh as in, current implementation is to put it in Component library which don't have tiptap installed
There was a problem hiding this comment.
eh bad phrasing on my end, i meant since this part comes from tiptap, we can shift over to studio!
…display-block-contents-for-identification
…display-block-contents-for-identification
…ngohjw/isom-1655-display-block-contents-for-identification
Problem
Closes https://linear.app/ogp/issue/ISOM-1655/display-block-contents-for-identification
Solution
Breaking Changes
Features:
Screenshots
(refer to storybook for full list of examples)