Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump @sentry/cli from 1.67.2 to 1.75.2 #2231

Merged
merged 1 commit into from
Jul 12, 2023
Merged

build(deps): bump @sentry/cli from 1.67.2 to 1.75.2 #2231

merged 1 commit into from
Jul 12, 2023

Conversation

halfwhole
Copy link
Collaborator

@halfwhole halfwhole commented Jun 26, 2023 •
edited
Loading

Problem

Go is currently using @sentry/cli v1.67.2 that has a dependency on ansi-regex v2.1.1, which has a ReDoS vulnerability

Closes Snyk issue

Solution

Upgrade @sentry/cli v1.67.2 to v1.75.2, which removes its use of ansi-regex v2.1.1

We use the overrides field in package.json to upgrade the @sentry/cli version -- see StackOverflow answer for more details on overrides

Tests

  • Test manually on staging to ensure that the main flows work well

gweiying
gweiying approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@gweiying gweiying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@halfwhole halfwhole force-pushed the build/deps/update-sentry-cli branch from 8d3baa5 to 6b9231b Compare July 12, 2023 06:55
@halfwhole halfwhole merged commit 7038820 into develop Jul 12, 2023
16 checks passed
@halfwhole halfwhole deleted the build/deps/update-sentry-cli branch July 12, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gweiying gweiying gweiying approved these changes

@thanhdatle thanhdatle Awaiting requested review from thanhdatle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@halfwhole @gweiying