Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react): remove strict mode, temporarily #7755

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix(react): remove strict mode, temporarily #7755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions frontend/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,15 @@ window.gtag = gtag
// Init dayjs
dayjs.init()

createRoot(document.getElementById('root')!).render(
<React.StrictMode>
<App />
</React.StrictMode>,
)
/**
* TODO(FRM-1855): Disable strict mode for validation to work properly
* This is not meant to be a permenant solution as the need to disable this
* reveals that there could be an existing issue with useEffect cleanup that is prevent
* pre-react 18.
*/
// createRoot(document.getElementById('root')!).render(
// <React.StrictMode>
// <App />,
// </React.StrictMode>,
// )
createRoot(document.getElementById('root')!).render(<App />)
Loading