Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release v6.150.0 #7741

Merged
merged 7 commits into from
Oct 3, 2024
Merged

build: release v6.150.0 #7741

merged 7 commits into from
Oct 3, 2024

Conversation

kevin9foong
Copy link
Contributor

@kevin9foong kevin9foong commented Oct 2, 2024 •
edited
Loading

New

Tests

fix: ordering of arguments for bounce service functions #7739

sendBouncedSubmissionSms and sendFormDeactivatedSms: Admins with email submissions bounced should receive SMS notification thru Postman

  • Login as admin
  • Update your emergency contact number through Profile > Emergency Contact > Verify
  • Create an email form, set the email notification email targets to be invalid emails eg, abc@xyz098.com and abcxyz!@open.gov.sg
  • As a respondent, make a submission to form (since all emails are invalid and bounce, a 'critical' bounce where all emails to notify have bounced occurs which triggers the next 2 emails)
  • Ensure that bounce SMS is received on number and form deactivated SMS is received. (note that 2 sms should be received)

dependabot bot and others added 7 commits September 26, 2024 13:12
@dependabot
fix(deps): bump @joi/date from 2.1.0 to 2.1.1 (#7723)
a6a71ca 
Bumps [@joi/date](https://github.com/sideway/joi-date) from 2.1.0 to 2.1.1.
- [Commits](hapijs/joi-date@v2.1.0...v2.1.1)

---
updated-dependencies:
- dependency-name: "@joi/date"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@kevin9foong
Merge pull request #7727 from opengovsg/release-al2
ba9a723 
build: merge release v6.149.0 to develop
@KenLSM
chore: allow empty coveralls to pass (#7726)
29ace47
@KenLSM @kevin9foong
chore: remove container naming on docker-compose (#7721)
10b7952 
Co-authored-by: Kevin Foong <kevin9foong@gmail.com>
@KenLSM
Merge pull request #7740 from opengovsg/release-al2
98012e6 
build: merge v6.149.3 to develop
@kevin9foong
fix: ordering of arguments for bounce service functions (#7739)
5443514
@kevin9foong
chore: bump version to v6.150.0
5c5a215
@datadog-opengovsg
Copy link

Datadog Report

Branch report: release_v6.150.0
Commit report: 5c5a215
Test service: formsg

✅ 0 Failed, 353 Passed, 0 Skipped, 1m 1.95s Total duration (6m 31.11s time saved)

@kevin9foong
Copy link
Contributor Author

verified and tested!

@kevin9foong
Copy link
Contributor Author

telegram-cloud-photo-size-5-6336836788114540021-y
example of test

@KenLSM KenLSM merged commit fff5011 into release-al2 Oct 3, 2024
45 of 46 checks passed
@KenLSM KenLSM deleted the release_v6.150.0 branch October 3, 2024 05:11
@KenLSM KenLSM mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenLSM KenLSM KenLSM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevin9foong @KenLSM