feat: add model fields to represent translations for form fields #7457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenLSM
reviewed
Jul 1, 2024
shared/types/form/form.ts
Outdated
| @@ -60,12 +73,24 @@ export enum FormAuthType { | |||
| SGID_MyInfo = 'SGID_MyInfo', | |||
| } | |||
|
|
|||
| export enum Language { | |||
| ENGLISH = 'English', | |||
There was a problem hiding this comment.
Recommend to use unicode locales for the values since we might be supporting localization for other countries.
ENGLISH = 'en-SG',
CHINESE = 'zh-SG',
MALAY = 'ms-SG',
TAMIL = 'ta-SG',
^ opting to stick to the simpler "ISO 639 two-letter language codes and ISO 3166 two-letter country codes".
siddarth2824
added a commit
that referenced
this pull request
Aug 8, 2024
* feat: add fields in model to represent translations for form fields * feat: add shared types to represent form field translations * fix: use unicode locales
siddarth2824
added a commit
that referenced
this pull request
Sep 22, 2024
* feat: add fields in model to represent translations for form fields * feat: add shared types to represent form field translations * fix: use unicode locales
siddarth2824
added a commit
that referenced
this pull request
Oct 15, 2024
* feat: add fields in model to represent translations for form fields * feat: add shared types to represent form field translations * fix: use unicode locales
siddarth2824
added a commit
that referenced
this pull request
Oct 15, 2024
* feat: add fields in model to represent translations for form fields * feat: add shared types to represent form field translations * fix: use unicode locales
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes
TranslationMappingwhich represents the translations for the specific languagetitleTranslationsanddescriptionTranslationsforbaseFieldtypeparagraphTranslationsforstartPagetypefieldOptionsTranslationsforCheckboxFieldSchema,RadioFieldSchemaandDropdownFieldSchema