Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: misc UI changes on Payment Summary page #6613

Merged
merged 3 commits into from
Aug 11, 2023
Merged

fix: misc UI changes on Payment Summary page #6613

merged 3 commits into from
Aug 11, 2023

Conversation

wanlingt
Copy link
Contributor

Solution

  • Spacing between title and description for thank you page is 12px
  • Font colours follow OGP base design system
  • Increase spacing from feedback section to recaptcha button - 24px
  • Proof of payment button stretches to the width of the screen for mobile

Improvements:

  • Added some content colour mappings from OGP DS as an interim solution, while we wait for the full colour tokens (FRM-1251)

@wanlingt wanlingt changed the title fix: misc UI changes on Payment summary page fix: misc UI changes on Payment Summary page Aug 11, 2023
@wanlingt wanlingt requested a review from KenLSM August 11, 2023 10:57
KenLSM
KenLSM approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Let's merge this in

@KenLSM KenLSM merged commit 1be6382 into feat/payment-by-products Aug 11, 2023
20 checks passed
@KenLSM KenLSM deleted the fix/ui branch August 11, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenLSM KenLSM KenLSM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wanlingt @KenLSM