fix: remove unused expressions, remove unused ts-ignores, add explici…

…t ignores
opengovsg · Oct 15, 2024 · 8fed177 · 8fed177
1 parent edde6db
commit 8fed177
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 5 deletions.
diff --git a/frontend/src/features/admin-form/settings/SettingsPage.tsx b/frontend/src/features/admin-form/settings/SettingsPage.tsx
@@ -150,7 +150,6 @@ export const SettingsPage = (): JSX.Element => {
         index={tabIndex === -1 ? 0 : tabIndex}
         onChange={(index) => {
           handleTabChange(index)
-          tabConfig[index]
         }}
       >
         <Flex

diff --git a/frontend/src/mocks/msw/handlers/admin-form/form.ts b/frontend/src/mocks/msw/handlers/admin-form/form.ts
@@ -669,7 +669,6 @@ export const createFormBuilderMocks = (
           _id: cuid(),
         } as FormFieldDto
         if (req.body.fieldType === BasicField.Table) {
-          // eslint-disable-next-line @typescript-eslint/no-extra-semi
           ;(newField as TableFieldDto).columns = req.body.columns.map(
             (col) => ({
               ...col,

diff --git a/frontend/src/typings/react-table-config.d.ts b/frontend/src/typings/react-table-config.d.ts
@@ -17,6 +17,7 @@ declare module 'react-table' {
       // feature set, this is a safe default.
       Record<string, any> {}
 
+  // eslint-disable-next-line @typescript-eslint/no-empty-object-type
   export interface Hooks<
     D extends Record<string, unknown> = Record<string, unknown>,
   > extends UseSortByHooks<D> {}

diff --git a/frontend/src/utils/__tests__/datadog.tests.ts b/frontend/src/utils/__tests__/datadog.tests.ts
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-require-imports */
 describe('datadogRum', () => {
   describe('DD_RUM is undefined', () => {
     beforeEach(() => {
@@ -11,7 +12,6 @@ describe('datadogRum', () => {
     it('should return a noop function for addAction', () => {
       // Arrange
 
-      // eslint-disable-next-line @typescript-eslint/no-var-requires
       const datadogRum = require('../datadog').datadogRum
       // Assert
       expect(window.DD_RUM).not.toBeDefined()
@@ -35,7 +35,6 @@ describe('datadogRum', () => {
 
     it('should call addAction without throwing', () => {
       // Arrange
-      // eslint-disable-next-line @typescript-eslint/no-var-requires
       const datadogRum = require('../datadog').datadogRum
 
       // Assert

diff --git a/frontend/src/utils/date.ts b/frontend/src/utils/date.ts
@@ -110,7 +110,6 @@ export const mutableTransformAllIsoStringsToDate = (body: unknown) => {
   for (const key of Object.keys(body)) {
     const value = (body as Record<string, unknown>)[key]
     if (isIsoDateString(value)) {
-      // eslint-disable-next-line @typescript-eslint/no-extra-semi
       ;(body as Record<string, unknown>)[key] = parseISO(value)
     } else if (typeof value === 'object') {
       mutableTransformAllIsoStringsToDate(value)