Skip to content

Conversation

@SeqLaz
Copy link
Member

@SeqLaz SeqLaz commented Aug 29, 2024

No description provided.

@SeqLaz SeqLaz requested a review from suricactus August 29, 2024 12:47
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go over the whole docs once again, as the coments I made were not always properly aligned. Please squash and force push a single commit.

@SeqLaz SeqLaz force-pushed the upstreaming-docs-in-sdk branch 2 times, most recently from f2217c8 to 3979a80 Compare August 31, 2024 15:52
@SeqLaz SeqLaz force-pushed the upstreaming-docs-in-sdk branch from f03a70b to 182514a Compare August 31, 2024 16:53
Co-authored-by: Mathieu Pellerin <nirvn.asia@gmail.com>
SeqLaz and others added 21 commits September 3, 2024 15:39
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
@suricactus
Copy link
Collaborator

Let's merge for now!

@suricactus suricactus merged commit 2651eca into master Sep 8, 2024
@suricactus suricactus deleted the upstreaming-docs-in-sdk branch September 8, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants