Update The Settlers I, II & III details #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxong
reviewed
Aug 1, 2018
originals/t.yaml
Outdated
| @@ -76,13 +76,26 @@ | |||
| meta: | |||
| genre: [Action, Adventure] | |||
|
|
|||
| - name: The Settlers II | |||
| - name: [The Settlers, The Settlers (video game)] | |||
| names: [Die Siedler II, Serf City] | |||
There was a problem hiding this comment.
is this right? The Settlers is also called "Die Siedler II"?
There was a problem hiding this comment.
There was a problem hiding this comment.
That's a good catch, it's Die Siedler and not Die Siedler II
originals/t.yaml
Outdated
| meta: | ||
| genre: [RTS] | ||
| subgenre: [City Building] | ||
| theme: [Medieval, Egyptian, Alternate Historical, Fantasy] |
There was a problem hiding this comment.
I don't think Medieval is right here, from the description it seems more like mythological, and for time period antiquity or ancient history. Unfortunately the Giant Bomb themes aren't the best. It would be good to come up with a better set of themes later.
There was a problem hiding this comment.
Shall we create Medieval? For now?
There was a problem hiding this comment.
I would have used Ancient if that was a theme, unfortunately it isn't :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some missing details, original names, American release names, fixed images, added links.