Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead images should show a placeholder image instead of text #2102

Closed
PQCraft opened this issue May 3, 2023 · 0 comments
Closed

Dead images should show a placeholder image instead of text #2102

PQCraft opened this issue May 3, 2023 · 0 comments
Assignees

Comments

@PQCraft
Copy link
Contributor

PQCraft commented May 3, 2023

Dead images currently show the game name in large text instead of a placeholder image and it doesn't look very good imo.
Screenshot_20230503_101236
This can be done with <object></object> I think which will load the contents inside the tag if it couldn't load whatever you passed to data.

<object data="https://site.com/images/icon1.png">
    <image src="https://site.com/images/noexist.png" />
</object>

The code above should load and display noexist.png if it fails to load icon1.png

cxong added a commit that referenced this issue May 7, 2023
@cxong cxong self-assigned this May 7, 2023
@cxong cxong closed this as completed in 70c2756 May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants