[ofParameterGroup] removed parameterIndex #6577
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rGroup by name are done directly onto parameters vector.
Contributor
Author
|
Better fix for the same bug: #6614 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for addressing the issue described on #6576.
This removes the usage of parameterIndex as does not keep track of the changes in names of ofParameters inside the group.
I have also used the already implemented methods to avoid code duplication. (used
contains()orgetPosition()).Worried about performance with this change, I run the unitTest for parameter and found that the change in time is negligible. (About 300 microseconds for both current implementation and this branch).
I can edit the parameter test to show the fix if that is needed.
Eduard