Regression: ofGetFrameRate is always off by +0.5 fps

[dimitre]

if you set framerate to 30 and read framerate it shows something like
30.5003 in macOS

I know it is about the reading because my alternative FPS display function is showing correct fps

Maybe it is related to this commit
a34ab60
cc: @danoli3

[Jonathhhan]

I can confirm this with Windows. Setting to 60 (or any other rate) is the same, always + 0.5.

[danoli3]

What time mode are you using? Those changes were only for one specific mode that was non functional

…

On Wed, 19 Feb 2025 at 12:56 pm, Jonathan Frank ***@***.***> wrote: I can confirm this with Windows. Setting to 60 (or any other rate) is the same, always + 0.5. — Reply to this email directly, view it on GitHub <#8271 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGK2HHODKHMLH5SIUMXTQL2QPQETAVCNFSM6AAAAABXM35SLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRXGMZDKNRUGY> . You are receiving this because you were mentioned.Message ID: ***@***.***> [image: Jonathhhan]*Jonathhhan* left a comment (openframeworks/openFrameworks#8271) <#8271 (comment)> I can confirm this with Windows. Setting to 60 (or any other rate) is the same, always + 0.5. — Reply to this email directly, view it on GitHub <#8271 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGK2HHODKHMLH5SIUMXTQL2QPQETAVCNFSM6AAAAABXM35SLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRXGMZDKNRUGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[dimitre]

I have no idea of time mode.
steps to reproduce are just set framerate, and write results to the screen

[dimitre]

I think this one is really important to be addressed before 0.12.1 release @ofTheo @danoli3

[danoli3]

Can you give me your sample FPS code as above, im not seeing this with System I shall do analysis might be the change around update storing, meaning it might be superficial only

[danoli3]

send on slack if private just snipped so I test exactly ur scenario

[dimitre]

just use;
ofSetFrameRate(30)
and print the result

[ofTheo]

@dimitre it does seem related to that commit.
I reverted to the previous commit and the fps went from 60.5 to 60.0024

master:

previous ofFpsCounter version:

[dimitre]

yes I suspect the 0.5s removed in this commit was important

if(!timestamps.empty() && timestamps.front() + 0.5s < now){

[ofTheo]

I tried reverting just that function and no change.
Struggling to track it down.

Only thing that works so far is revert both files and then make changes to ofCoreEvents to match the older api.