-
Notifications
You must be signed in to change notification settings - Fork 6
Release sage 2.0.0 opt/torsion #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
QCSubmit Validation Report
QC Specification Report
QCSubmit version information(click to expand)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Largely LGTM, just a few minor nitpicks!
...024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/generate-combined-dataset.py
Outdated
Show resolved
Hide resolved
...024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/generate-combined-dataset.py
Outdated
Show resolved
Hide resolved
...024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/generate-combined-dataset.py
Outdated
Show resolved
Hide resolved
submissions/2024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/README.md
Outdated
Show resolved
Hide resolved
submissions/2024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/README.md
Outdated
Show resolved
Hide resolved
submissions/2024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/README.md
Outdated
Show resolved
Hide resolved
submissions/2024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/ds_info.json
Outdated
Show resolved
Hide resolved
QCSubmit Validation Report
QC Specification Report
QCSubmit version information(click to expand)
|
QCSubmit Validation Report
QC Specification Report
QCSubmit version information(click to expand)
|
QCSubmit Validation Report
QC Specification Report
QCSubmit version information(click to expand)
|
QCSubmit Validation Report
QC Specification Report
QCSubmit version information(click to expand)
|
…g-Dataset-v1.0/generate-combined-dataset.py Co-authored-by: Lily Wang <31115101+lilyminium@users.noreply.github.com>
QCSubmit Validation Report
QC Specification Report
QCSubmit version information(click to expand)
|
QCSubmit Validation Report
QC Specification Report
QCSubmit version information(click to expand)
|
@lilyminium Because of how this works, I can't generate the statistics until I make the dataset. If everything that is here now looks good then I'll run this before merging so that if I need any tweaks I can record them without a PR. |
To do (from live discussion):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Largely LGTM Jen, I added some nitpicky comments to the description and the version number should be updated :-)
submissions/2025-02-10-OpenFF-Sage-2.0.0-Optimization-Training-Dataset-v1.1/README.md
Outdated
Show resolved
Hide resolved
submissions/2025-02-10-OpenFF-Sage-2.0.0-Optimization-Training-Dataset-v1.1/README.md
Outdated
Show resolved
Hide resolved
submissions/2025-02-10-OpenFF-Sage-2.0.0-Optimization-Training-Dataset-v1.1/README.md
Outdated
Show resolved
Hide resolved
submissions/2025-02-10-OpenFF-Sage-2.0.0-Optimization-Training-Dataset-v1.1/README.md
Outdated
Show resolved
Hide resolved
submissions/2025-02-10-OpenFF-Sage-2.0.0-Optimization-Training-Dataset-v1.1/ds_info.json
Outdated
Show resolved
Hide resolved
submissions/2025-02-10-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/README.md
Outdated
Show resolved
Hide resolved
submissions/2025-02-10-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/README.md
Outdated
Show resolved
Hide resolved
submissions/2025-02-10-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/README.md
Outdated
Show resolved
Hide resolved
submissions/2025-02-10-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/ds_info.json
Outdated
Show resolved
Hide resolved
submissions/2025-05-01-OpenFF-Sage-2.0.0-Optimization-Training-Dataset-v1.1/README.md
Outdated
Show resolved
Hide resolved
Otherwise LGTM -- thanks @jaclark5! Feel free to run :-) |
Blocked: Copying the torsion drive records resulted in 115 of 713 records being duplicated, despite a DeepDiff showing only the record id and date of creation are changed. This PR is blocked until this is resolved. |
New Submission Checklist
README.md
describing the dataset see here for examplesdataset*.json
; may feature a compression extension, such as.bz2
README.md