Skip to content

Release sage 2.0.0 opt/torsion #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

jaclark5
Copy link
Collaborator

@jaclark5 jaclark5 commented Dec 18, 2024

New Submission Checklist

  • Created a new folder in the submissions directory containing the dataset
  • Added README.md describing the dataset see here for examples
  • All files used to produce the dataset are included with a description
  • Dataset follows the QCSubmit schema defined for Datasets, OptimizationDatasets and TorsionDriveDatasets
  • Dataset filename matches pattern dataset*.json; may feature a compression extension, such as .bz2
  • A PDF depicting the molecules is attached, in the case of torsiondrives this should include the highlighting of the central bond, this can be done automatically using qcsubmit.
  • QCSubmit validation passed
  • Made a new dataset entry in the mapping table in repository README.md
  • Ready to submit!

@openff-dangerbot
Copy link
Contributor

QCSubmit Validation Report

submissions/2024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/dataset.json.bz2
Dataset Name OpenFF Sage 2.0.0 Torsion Drive Training Dataset v1.0
Dataset Type TorsionDriveDataset
Elements N ,H ,P ,C ,S ,I ,Cl ,Br ,O ,F
Valid Cmiles 🔥
Connected Dihedrals 🔥
No Linear Torsions 🔥
No Molecular Complexes 🔥
Valid Constraints 🔥
Complete Metatdata 🔥

QC Specification Report

submissions/2024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/dataset.json.bz2/default
Specification Name default
Method B3LYP-D3BJ
Basis DZVP
Wavefunction Protocol none
Implicit Solvent
Keywords {}
Validated 🔥
Valid SCF Properties 🔥
Full Basis Coverage 🔥
QCSubmit version information(click to expand)
version
openff.qcsubmit 0.54.0
openff.toolkit 0.16.7
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.09.3

Copy link
Contributor

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely LGTM, just a few minor nitpicks!

@openff-dangerbot
Copy link
Contributor

QCSubmit Validation Report

submissions/2024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/dataset.json.bz2
Dataset Name OpenFF Sage 2.0.0 Torsion Drive Training Dataset v1.0
Dataset Type TorsionDriveDataset
Elements N ,P ,H ,I ,C ,Br ,S ,O ,F ,Cl
Valid Cmiles 🔥
Connected Dihedrals 🔥
No Linear Torsions 🔥
No Molecular Complexes 🔥
Valid Constraints 🔥
Complete Metatdata 🔥

QC Specification Report

submissions/2024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/dataset.json.bz2/default
Specification Name default
Method B3LYP-D3BJ
Basis DZVP
Wavefunction Protocol none
Implicit Solvent
Keywords {}
Validated 🔥
Valid SCF Properties 🔥
Full Basis Coverage 🔥
QCSubmit version information(click to expand)
version
openff.qcsubmit 0.54.0
openff.toolkit 0.16.7
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.09.3

@openff-dangerbot
Copy link
Contributor

QCSubmit Validation Report

submissions/2024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/dataset.json.bz2
Dataset Name OpenFF Sage 2.0.0 Torsion Drive Training Dataset v1.0
Dataset Type TorsionDriveDataset
Elements N ,P ,H ,I ,C ,Br ,S ,O ,F ,Cl
Valid Cmiles 🔥
Connected Dihedrals 🔥
No Linear Torsions 🔥
No Molecular Complexes 🔥
Valid Constraints 🔥
Complete Metatdata 🔥

QC Specification Report

submissions/2024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/dataset.json.bz2/default
Specification Name default
Method B3LYP-D3BJ
Basis DZVP
Wavefunction Protocol none
Implicit Solvent
Keywords {}
Validated 🔥
Valid SCF Properties 🔥
Full Basis Coverage 🔥
QCSubmit version information(click to expand)
version
openff.qcsubmit 0.54.0
openff.toolkit 0.16.7
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.09.3

@openff-dangerbot
Copy link
Contributor

QCSubmit Validation Report

submissions/2024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/dataset.json.bz2
Dataset Name OpenFF Sage 2.0.0 Torsion Drive Training Dataset v1.0
Dataset Type TorsionDriveDataset
Elements N ,P ,H ,I ,C ,Br ,S ,O ,F ,Cl
Valid Cmiles 🔥
Connected Dihedrals 🔥
No Linear Torsions 🔥
No Molecular Complexes 🔥
Valid Constraints 🔥
Complete Metatdata 🔥

QC Specification Report

submissions/2024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/dataset.json.bz2/default
Specification Name default
Method B3LYP-D3BJ
Basis DZVP
Wavefunction Protocol none
Implicit Solvent
Keywords {}
Validated 🔥
Valid SCF Properties 🔥
Full Basis Coverage 🔥
QCSubmit version information(click to expand)
version
openff.qcsubmit 0.54.0
openff.toolkit 0.16.7
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.09.3

@openff-dangerbot
Copy link
Contributor

QCSubmit Validation Report

submissions/2024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/dataset.json.bz2
Dataset Name OpenFF Sage 2.0.0 Torsion Drive Training Dataset v1.0
Dataset Type TorsionDriveDataset
Elements N ,P ,H ,I ,C ,Br ,S ,O ,F ,Cl
Valid Cmiles 🔥
Connected Dihedrals 🔥
No Linear Torsions 🔥
No Molecular Complexes 🔥
Valid Constraints 🔥
Complete Metatdata 🔥

QC Specification Report

submissions/2024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/dataset.json.bz2/default
Specification Name default
Method B3LYP-D3BJ
Basis DZVP
Wavefunction Protocol none
Implicit Solvent
Keywords {}
Validated 🔥
Valid SCF Properties 🔥
Full Basis Coverage 🔥
QCSubmit version information(click to expand)
version
openff.qcsubmit 0.54.0
openff.toolkit 0.16.7
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.09.3

…g-Dataset-v1.0/generate-combined-dataset.py

Co-authored-by: Lily Wang <31115101+lilyminium@users.noreply.github.com>
@openff-dangerbot
Copy link
Contributor

QCSubmit Validation Report

submissions/2024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/dataset.json.bz2
Dataset Name OpenFF Sage 2.0.0 Torsion Drive Training Dataset v1.0
Dataset Type TorsionDriveDataset
Elements N ,P ,H ,I ,C ,Br ,S ,O ,F ,Cl
Valid Cmiles 🔥
Connected Dihedrals 🔥
No Linear Torsions 🔥
No Molecular Complexes 🔥
Valid Constraints 🔥
Complete Metatdata 🔥

QC Specification Report

submissions/2024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/dataset.json.bz2/default
Specification Name default
Method B3LYP-D3BJ
Basis DZVP
Wavefunction Protocol none
Implicit Solvent
Keywords {}
Validated 🔥
Valid SCF Properties 🔥
Full Basis Coverage 🔥
QCSubmit version information(click to expand)
version
openff.qcsubmit 0.54.0
openff.toolkit 0.16.7
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.09.3

@jaclark5 jaclark5 requested a review from lilyminium December 19, 2024 19:01
@openff-dangerbot
Copy link
Contributor

QCSubmit Validation Report

submissions/2024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/dataset.json.bz2
Dataset Name OpenFF Sage 2.0.0 Torsion Drive Training Dataset v1.0
Dataset Type TorsionDriveDataset
Elements N ,P ,H ,I ,C ,Br ,S ,O ,F ,Cl
Valid Cmiles 🔥
Connected Dihedrals 🔥
No Linear Torsions 🔥
No Molecular Complexes 🔥
Valid Constraints 🔥
Complete Metatdata 🔥

QC Specification Report

submissions/2024-12-17-OpenFF-Sage-2.0.0-Torsion-Drive-Training-Dataset-v1.0/dataset.json.bz2/default
Specification Name default
Method B3LYP-D3BJ
Basis DZVP
Wavefunction Protocol none
Implicit Solvent
Keywords {}
Validated 🔥
Valid SCF Properties 🔥
Full Basis Coverage 🔥
QCSubmit version information(click to expand)
version
openff.qcsubmit 0.54.0
openff.toolkit 0.16.7
basis_set_exchange 0.10
qcelemental 0.28.0
rdkit 2024.09.3

@jaclark5 jaclark5 marked this pull request as draft January 27, 2025 19:21
@jaclark5 jaclark5 changed the title Release sage 2.0.0 torsion Release sage 2.0.0 opt/torsion Feb 11, 2025
@jaclark5
Copy link
Collaborator Author

@lilyminium Because of how this works, I can't generate the statistics until I make the dataset. If everything that is here now looks good then I'll run this before merging so that if I need any tweaks I can record them without a PR.

@jameseastwood jameseastwood assigned lilyminium and unassigned jaclark5 Apr 29, 2025
@lilyminium
Copy link
Contributor

To do (from live discussion):

  • I'll check the metadata
  • JC runs the code once approved
  • JC will merge the PR after checking results

Copy link
Contributor

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely LGTM Jen, I added some nitpicky comments to the description and the version number should be updated :-)

@jameseastwood jameseastwood assigned jaclark5 and unassigned lilyminium May 1, 2025
@jaclark5 jaclark5 marked this pull request as ready for review May 1, 2025 16:49
@lilyminium
Copy link
Contributor

Otherwise LGTM -- thanks @jaclark5! Feel free to run :-)

@jaclark5
Copy link
Collaborator Author

jaclark5 commented May 5, 2025

Blocked: Copying the torsion drive records resulted in 115 of 713 records being duplicated, despite a DeepDiff showing only the record id and date of creation are changed. This PR is blocked until this is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

3 participants