Skip to content

[WIP] Bond parameter interpolation based on Wiberg bond orders #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[WIP] Bond parameter interpolation based on Wiberg bond orders #501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openforcefield/typing/engines/smirnoff/parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1875,7 +1875,7 @@ def create_force(self, system, topology, **kwargs):
if bond.fractional_bond_order is None:
[k, length] = [bond_params.k, bond_params.length]
else:
# Interpolate using fractional bond orders
# TODO: Interpolate using fractional bond orders
# TODO: Do we really want to allow per-bond specification of interpolation schemes?
order = bond.fractional_bond_order
if self.fractional_bondorder_interpolation == 'interpolate-linear':
Expand Down