-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on MacOS and remove progress bar from example #159
base: main
Are you sure you want to change the base?
Conversation
Oops didn't mean to reformat the workflow yaml :/ will fix once I know if this worked |
.github/workflows/examples-ci.yaml
Outdated
|
||
fail-fast: false | ||
matrix: | ||
os: [macOS-12, ubuntu-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macos-12
is being removed next month 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is macos-latest
appropriate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think so, it's no longer intel but AmberTools doesn't work on macOS-13. Thanks so much for looking at this!
Hey look it seems to have worked! I've switched to |
Ok looks like there are fun new errors to deal with. Not sure I have any insight on these ones, I've tried a few things and if this one doesn't work I'm out of ideas. If the current round of tests fail, I can revert to |
Thanks so much for fixing the issue @Yoshanuikabundi, you are a wizard!!
What an exotic new error I've never seen before, even when Mac examples was running, haha. It looks like this? actions/runner-images#9918 So not easily fixable with until macos-15 is out, and with macos-13 out of the ambertools picture, downgrading to macos-12 seems the only way for CI to pass (until macos-12 disappears.) Edit: unless there's a way to tell torch not to use mps? |
matrix: | ||
os: [macOS-latest, ubuntu-latest] | ||
python-version: ["3.11", "3.12"] | ||
pydantic-version: ["2"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to be a bit of a nitpicker, but this could also go away (and below)
Fixes #133
Changes made in this Pull Request:
The timeout that's being triggered is not the cell timeout (default about 30 minutes), but a hard coded one for the notebook kernel to transmit the cell's output to nbval. My hypothesis is that the fit takes serious time and the progress bar is constantly sending updates to the output, producing more output than can be processed in 5 seconds. Platform differences may reflect that the MacOS runners take more time (and therefore produce more progress bar updates), or something weird to do with how outputs are transmitted.
PR Checklist