fix: 2255 - safer setState call after async code #3345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted file: * `history_page.dart`: safer setState call after async code
Deleted file: * `registration_login_test.dart` Impacted file: * `labeler.yml`: removed a failing test that had more to do with off-dart than with Smoothie, and that relied on the notoriously unstable TEST env
M123-dev
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted file:
history_page.dart: safer setState call after async codeWhat
StatefulWidgets, it's a good practice to checkif(mounted)after each async call that precedes asetStateor a reference to thecontext(cf. Fix: use_build_context_synchronously #1815, https://stackoverflow.com/questions/49340116/setstate-called-after-dispose/50337157#50337157)Fixes bug(s)
Fixes: #2255
Fixes SMOOTHIE-WS