New picture: Systematic choice - gallery or camera

[monsieurtanuki]

Problem

On my ios emulator the camera does not work.
In some cases in Smoothie, you can select gallery or camera. In other cases, it's only camera (which always fails in my case).

Proposed solution

For UX consistency and better dev options, I would suggest to always propose gallery or camera as a picture source.

Additional context

This is already the case in edit product page / edit ingredients, basically the fix could be to put true as the default value for the "should we ask?" parameter in startImageCropping:

[g123k]

The camera is not supported on the iOS simulator, reason why you have this issue.
But it would be interesting to remove the camera choice when no camera is available

[AshAman999]

I agree with @monsieurtanuki here, I noticed there are few screens where we aren't letting the user select if they want to click picture or select one,
The default behavior should be to ask the user for either by default

[monsieurtanuki]

@g123k My point here was to always give the user the choice of gallery, which would solve my issue AND bring consistency in the app.
Your suggestion of removing the camera choice when not available is interesting too, and goes a bit beyond this issue. What is the code to detect that the camera is not available?

[g123k]

@g123k My point here was to always give the user the choice of gallery, which would solve my issue AND bring consistency in the app. Your suggestion of removing the camera choice when not available is interesting too, and goes a bit beyond this issue. What is the code to detect that the camera is not available?

In the CameraHelper, you have a dedicated method

smooth-app/packages/smooth_app/lib/helpers/camera_helper.dart

Line 19 in eef4c45

static bool get hasACamera {

[monsieurtanuki]

Thank you @g123k, that works like a charm!