feat: Automatically unselect images when source image deleted Issue#9793 #9950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding my username in admins list first so that I can edit the Images.pm
…deleted First checked if selected image id is equal to image id and then deleted the image id as the siurce image is already deleted
|
| @@ -1213,6 +1213,12 @@ sub process_image_move ($user_id, $code, $imgids, $move_to, $ownerid) { | |||
|
|
|||
| delete $product_ref->{images}{$imgid}; | |||
|
|
|||
| # Check if any selected image's imgid equals the deleted imgid | |||
There was a problem hiding this comment.
We want to check if the value of the "imgid" field of a selected field is equal to $imgid.
To verify the problem, see steps: #9793 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
##What?
Issue#9793 that states that images should be automatically unselected when their source image is deleted
# Why?
This saves time for contributors on problematic images, and avoid forgetting to unselect it.
# How?
First checked if selected image id is equal to image id and then deleted the image id as the siurce image is already deleted