-
-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Content should have some left and right margins in responsive mode #7498 #8098
base: main
Are you sure you want to change the base?
Conversation
Styles updated for small screen .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect @Dev-Ashank !
That's so great to see this kind of issue tackled :-)
Thanks. |
scss/_footer.scss
Outdated
margin-left: 0; | ||
} | ||
.title-5 { | ||
font-size: 1.2857142857rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this font-size so specific? Have you taken it from somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already there when I am testing in developer mode in chrome. I should have removed it.
font size removed.
} | ||
} | ||
|
||
@media #{$small-only} { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those changes might apply to a lot of other p tags elsewhere.
I would prefer to have a local rule like this one:
#contribute_and_discover_links_block {
.inline-list {
margin-left: rem-calc(-17);
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I tested it, the pagination works great. One small issue for medium size. Also I think a more local rule would be better. Thanks!
Thanks for reviewing PR and I would update for medium size also . I will always remember to apply local rule as much as possible Thanks for guidance ❤️. |
Hi @Dev-Ashank , just wondering if you still plan to work on this PR? Thanks! |
Yes I was waiting for feedback. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Styles updated for small screen .
What
Related issue(s) and discussion