feat: Eco-Score improvements and change of scale: A+ to F - DRAFT #10829
Conversation
github-actions
bot
added
🧪 tests
🌱 Eco-Score
teolemon
added
🤳🥫 blocking mobile apps
|
|
@teolemon Indeed this is the correct order: food, beauty, pet food, product. I've just managed to reproduce your screenshots:
The problem seems to be that the product was not found on food/dev. Then of course we're looking for it on beauty/dev, which can be problematic if the beauty/dev server is down or doesn't even exist. |
@teolemon That said, a behavior may have to be fixed: if we know for a fact that a product has a given product type (e.g. food), we should check only for this product type and ignore the other ones. Do you want me to implement that behavior? |
|
|
|
@monsieurtanuki @g123k Search queries also return an error message on the mobile app when using .dev, even though they seem to be successfull on the server: [27/Sep/2024:09:52:17 +0000] "POST /cgi/search.pl HTTP/1.0" 200 1431620 "-" "- Smoothie - OpenFoodFacts - 4.15.0+1345 - android+UP1A.231005.007.S911BXXS6CXGA - https://world.openfoodfacts.org/ - - Smoothie - OpenFoodFacts - 4.15.0+1345 - android+UP1A.231005.007.S911BXXS6CXGA - 6da31523-985c-4bf3-9d23-a58a9d014bf8" |
|
@stephanegigandet Sure of that? I've just tested on dev for OxF, with my local version and food@dev is OK.
|
|
@stephanegigandet I've also tried with real food on food@dev: couldn't find nutella in France, but in the world: |
|
po/tags/tags.pot:669: duplicate message definition... |
|
po/common/common.pot:7017: duplicate message definition... |
| msgctxt "attribute_ecoscore_grade_title" | ||
| msgid "Eco-Score %s" | ||
| msgstr "Eco-Score %s" | ||
|
|
||
| msgctxt "attribute_ecoscore_a_plus_description_short" | ||
| msgid "Very low environmental impact" |
There was a problem hiding this comment.
GetText will complain about duplicate ids like, and Crowdin will get confused and cross contaminate between the 2 strings
|
The Eco-Score has an improved formula:
https://docs.score-environnemental.com/more/changelog#id-19-septembre-2024
There are 2 small changes:
And there is a bigger more visible change:
Note: this is a draft. In particular, the images for the new A+ and F grades are for testing purposes only.
To ease testing of mobile apps etc. this PR has been deployed to the world.openfoodfacts.dev server (login and password: off)