Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: embedded description #10143

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Josckar
Copy link

@Josckar Josckar commented Apr 17, 2024

What

Added the line to pass canon_description to site_layout.tt.html
Mainly taken from closed PR #7589 (could not get in contact with user @ferb7o2 to understand why it was closed).

Related issue(s) and discussion

@Josckar Josckar requested a review from a team as a code owner April 17, 2024 17:34
@Josckar Josckar changed the title Fix embedded description fix: embedded description Apr 17, 2024
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@teolemon
Copy link
Member

Thank you @Josckar

@teolemon teolemon enabled auto-merge (squash) April 18, 2024 09:23
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.64%. Comparing base (dc04d18) to head (909d4d0).
Report is 248 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10143      +/-   ##
==========================================
+ Coverage   49.54%   49.64%   +0.10%     
==========================================
  Files          67       71       +4     
  Lines       20650    20977     +327     
  Branches     4980     5027      +47     
==========================================
+ Hits        10231    10415     +184     
- Misses       9131     9270     +139     
- Partials     1288     1292       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon
Copy link
Member

The following jobs failed:
+------------------------------------+------------------------------------+
| Job ID | Test File |
+------------------------------------+------------------------------------+
| 1148A50E-FD64-11EE-BB62-D97F01AF1E | tests/integration/api_v2_product_r |
| 41 | ead.t |
| | |
| 1148AD88-FD64-11EE-BB62-D97F01AF1E | tests/integration/api_v2_product_w |
| 41 | rite.t |
| | |
| 114BC63A-FD64-11EE-BB62-D97F01AF1E | tests/integration/web_html.t |
| 41 | |
| | |
| 11496034-FD64-11EE-BB62-D97F01AF1E | tests/integration/product_read.t |
| 41 | |
| | |
| 1149580A-FD64-11EE-BB62-D97F01AF1E | tests/integration/page_crawler.t |
| 41 | |
| | |
| 114BB4D8-FD64-11EE-BB62-D97F01AF1E | tests/integration/unknown_tags.t |
| 41 | |
| | |
| 11497196-FD64-11EE-BB62-D97F01AF1E | tests/integration/protected_produc |
| 41 | t.t |
+------------------------------------+------------------------------------+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Social media link preview missing website description
6 participants