-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Store deleted users in a table #14
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
============================================
+ Coverage 40.96% 42.50% +1.53%
- Complexity 24 51 +27
============================================
Files 13 17 +4
Lines 249 320 +71
Branches 11 15 +4
============================================
+ Hits 102 136 +34
- Misses 138 172 +34
- Partials 9 12 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Any reason why you added an extra event handler rather than putting the code in the existing one?
In my mind, one issue is that they'll never be totally transactional. All of this happens as the account has been removed from the store already. I started with all of the code in one handler, but having to |
What
Part of