Skip to content

refactor: modernize pointers to go 1.26 syntax #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marceloboeira merged 1 commit into from
Feb 20, 2026
Merged

refactor: modernize pointers to go 1.26 syntax #659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions pkg/handler/crud_flag_creation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (

"github.com/go-openapi/runtime/middleware"
"github.com/openflagr/flagr/pkg/entity"
"github.com/openflagr/flagr/pkg/util"
"github.com/openflagr/flagr/swagger_gen/models"
"github.com/openflagr/flagr/swagger_gen/restapi/operations/flag"
"github.com/prashantv/gostub"
Expand All @@ -29,7 +28,7 @@ func TestCrudCreateFlag(t *testing.T) {
t.Run("it should be able to create one flag", func(t *testing.T) {
res = c.CreateFlag(flag.CreateFlagParams{
Body: &models.CreateFlagRequest{
Description: util.StringPtr("funny flag"),
Description: new("funny flag"),
Key: "some_random_flag_key",
},
})
Expand All @@ -45,7 +44,7 @@ func TestCrudCreateFlag(t *testing.T) {
t.Run("it should be able to create simple_boolean_flag template", func(t *testing.T) {
res = c.CreateFlag(flag.CreateFlagParams{
Body: &models.CreateFlagRequest{
Description: util.StringPtr("simple flag"),
Description: new("simple flag"),
Key: "simple_boolean_flag_key",
Template: "simple_boolean_flag",
},
Expand Down Expand Up @@ -93,7 +92,7 @@ func TestCrudCreateFlagWithFailures(t *testing.T) {
defer gostub.StubFunc(&e2rMapFlag, nil, fmt.Errorf("e2r MapFlag error")).Reset()
res = c.CreateFlag(flag.CreateFlagParams{
Body: &models.CreateFlagRequest{
Description: util.StringPtr("funny flag"),
Description: new("funny flag"),
},
})
assert.NotZero(t, res.(*flag.CreateFlagDefault).Payload)
Expand All @@ -103,7 +102,7 @@ func TestCrudCreateFlagWithFailures(t *testing.T) {
db.Error = fmt.Errorf("db generic error")
res = c.CreateFlag(flag.CreateFlagParams{
Body: &models.CreateFlagRequest{
Description: util.StringPtr("funny flag"),
Description: new("funny flag"),
},
})
assert.NotZero(t, res.(*flag.CreateFlagDefault).Payload)
Expand All @@ -113,7 +112,7 @@ func TestCrudCreateFlagWithFailures(t *testing.T) {
t.Run("CreateFlag - invalid key error", func(t *testing.T) {
res = c.CreateFlag(flag.CreateFlagParams{
Body: &models.CreateFlagRequest{
Description: util.StringPtr(" flag with a space"),
Description: new(" flag with a space"),
Key: " 1-2-3", // invalid key
},
})
Expand All @@ -123,7 +122,7 @@ func TestCrudCreateFlagWithFailures(t *testing.T) {
t.Run("CreateFlag - invalid template error", func(t *testing.T) {
res = c.CreateFlag(flag.CreateFlagParams{
Body: &models.CreateFlagRequest{
Description: util.StringPtr(" flag with a space"),
Description: new(" flag with a space"),
Key: "invalid_template",
Template: "invalid_template",
},
Expand Down
Loading
Loading