Use a consistent instance key in AnimateLibrary to prevent leaked references. #36
Open
NipponSunrise wants to merge 1 commit intoopenfl:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch
AnimateLibraryto useinstanceIDas the sole key in instances. We now register/unregister underinstanceID(instead of the rawuuid), soinstances.set()andinstances.remove()hit the same key, preventing stale map entries afterunload()with no runtime behavior changes.Additional consideration
Rename
get(uuid:String)togetByInstanceID(key:String), update call sites, and document thatinstanceIDis the canonical lookup key going forward.