Bytes: Fix length from fromBytes on JS#2025
Open
Geokureli wants to merge 4 commits intoopenfl:developfrom
Open
Bytes: Fix length from fromBytes on JS#2025Geokureli wants to merge 4 commits intoopenfl:developfrom
Geokureli wants to merge 4 commits intoopenfl:developfrom
Conversation
Contributor
I also got 16 in Firefox on Linux. |
Contributor
Author
|
I also added a fix to haxe, but lime should probably account for this on older versions |
tobil4sk
reviewed
Jan 26, 2026
src/lime/utils/Bytes.hx
Outdated
| #if js | ||
| this = new HaxeBytes(bytesData); | ||
| // bytesData may have extra bytes. See https://github.com/HaxeFoundation/haxe/issues/8974 | ||
| this = new HaxeBytes(bytesData.slice(0, length)); |
Member
There was a problem hiding this comment.
slice copies the buffer, so perhaps another option might be to just manually override: this.length = length? (might require @:privateAccess)
Contributor
Author
There was a problem hiding this comment.
doesn't require @:privateAccess as the abstract has @:access(haxe.io.Bytes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potentially related to: openfl/openfl#2360
In JS the underlying byte data may have extras, due to the underlying types used in js, explained here: HaxeFoundation/haxe#8974. This pr will ignore those extras.
Example reproducing the inconsistent behavior:
Tested on chrome for mac