Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Python 3.8 and remove Python 3.6 #1111

Closed
wants to merge 5 commits into from

Conversation

MaxGhenis
Copy link
Contributor

@MaxGhenis MaxGhenis commented Feb 22, 2022

Technical changes

Creating as a draft as I'm not sure I've done the Python version matrix correctly. I'm guessing some of the jobs should not be matrixed. I also need to adjust my linter.

NB: Python 3.8.12 is the latest version of Python 3.8, per https://www.python.org/downloads.

@coveralls
Copy link

coveralls commented Feb 22, 2022

Coverage Status

Coverage increased (+0.02%) to 78.936% when pulling d91ecb8 on MaxGhenis:MaxGhenis/issue1035 into 49d95a0 on openfisca:master.

@MaxGhenis
Copy link
Contributor Author

numpy 1.17.0 is failing to install on Python 3.8. I don't understand why it's starting at numpy 1.19.0 to retrieve the most recent three versions, rather than 1.22.0, which is the latest numpy version and compatible with Python 3.8 (not 3.7).

@maukoquiroga I'd missed your #1031 when starting this. Could this serve as a simpler starting point to at least get 3.8 running?

@MattiSG
Copy link
Member

MattiSG commented Dec 13, 2022

Thanks @MaxGhenis for this suggestion, and sorry for not having been able to collaborate on it to face the stronger complexity than it initially looked 😔
Superseded by #1168, which will hopefully provide a scalable way to test Python versions in a matrix. Looking forward to progressively bring support for newer versions of Python!

@MattiSG MattiSG closed this Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Python 3.6 tags Test Python 3.8
3 participants