Issue found in in_yaml_test_reform.py:15:
reformed_parameters=dict, # Should be: reformed_parameters: dict
This is a type annotation bug - =dict sets the default to the dict class itself, not an empty dict. It should be : dict for type hint or = None for a default value.
Also in apply() method (line 26-27): The modify_parameters function ignores local_parameters and completely replaces the parameter tree. This seems intentional but the docstring says "similar to a parameter tree" - might be worth clarifying if this fully replaces or merges parameters.
Suggestion de Claude :
Originally posted by @benoit-cty in #1358 (comment)