Skip to content

Fix incomplete Issue #110 - change PREMode default to NOT_SET#1124

Closed
BurakKTopal wants to merge 1 commit intodevfrom
Kucuktopal_issue1108
Closed

Fix incomplete Issue #110 - change PREMode default to NOT_SET#1124
BurakKTopal wants to merge 1 commit intodevfrom
Kucuktopal_issue1108

Conversation

@BurakKTopal
Copy link
Collaborator

This PR replaces this original PR and fixes #110

The original fix in commit 64ed308 never worked because PREMode defaulted to INDCPA, not NOT_SET. This caused GetParamsPK() to always return Q×P basis for HYBRID, even when PRE is not needed.

Changes:

  • Set default PREMode to NOT_SET in gen-cryptocontext-params-defaults.h
  • Update pre-buffer.cpp to explicitly set PREMode=INDCPA

@dsuponitskiy
Copy link
Collaborator

dsuponitskiy commented Feb 14, 2026

Yuriy asked me to fix your original PR, so please do not reopen this one. We don’t need duplicate PRs. In addition, I’ve already started two extensive CI runs for the PR I opened.

@dsuponitskiy dsuponitskiy deleted the Kucuktopal_issue1108 branch February 14, 2026 12:49
@BurakKTopal
Copy link
Collaborator Author

@dsuponitskiy and @yspolyakov, I understand and respect the policy. If I may comment that I find the steps taken unusual: taking over someone else's work like this. I would have valued it a lot more to let me do it end-to-end and obtain full credits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incomplete Fix for Issue #110 - PREMode default causes public keys to always use Q×P basis when using HYBRID key switching

2 participants