Fix incomplete Issue #110 - change PREMode default to NOT_SET#1124
Closed
BurakKTopal wants to merge 1 commit intodevfrom
Closed
Fix incomplete Issue #110 - change PREMode default to NOT_SET#1124BurakKTopal wants to merge 1 commit intodevfrom
BurakKTopal wants to merge 1 commit intodevfrom
Conversation
Collaborator
|
Yuriy asked me to fix your original PR, so please do not reopen this one. We don’t need duplicate PRs. In addition, I’ve already started two extensive CI runs for the PR I opened. |
Collaborator
Author
|
@dsuponitskiy and @yspolyakov, I understand and respect the policy. If I may comment that I find the steps taken unusual: taking over someone else's work like this. I would have valued it a lot more to let me do it end-to-end and obtain full credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces this original PR and fixes #110
The original fix in commit 64ed308 never worked because PREMode defaulted to INDCPA, not NOT_SET. This caused GetParamsPK() to always return Q×P basis for HYBRID, even when PRE is not needed.
Changes: