Skip to content

fix(js-sdk): cache client credentials token #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2023
Merged

fix(js-sdk): cache client credentials token #90

merged 1 commit into from
Jan 23, 2023

Conversation

@rhamzeh
Copy link
Member

@rhamzeh rhamzeh commented Jan 23, 2023 •
edited
Loading

Description

Resolves an issue with caching client credentials token due to the credentials storage not being passed down.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@rhamzeh rhamzeh added the js-sdk Affects the JavaScript SDK label Jan 23, 2023
@rhamzeh rhamzeh self-assigned this Jan 23, 2023
@rhamzeh rhamzeh requested a review from a team as a code owner January 23, 2023 16:42
@rhamzeh rhamzeh mentioned this pull request Jan 23, 2023
Merged
@rhamzeh rhamzeh merged commit db80595 into main Jan 23, 2023
@rhamzeh rhamzeh deleted the fix/js-sdk-credentials-caching branch January 23, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adriantam adriantam adriantam approved these changes

Assignees

@rhamzeh rhamzeh

Labels

js-sdk Affects the JavaScript SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[JS SDK] Client Credentials bearer token is not cached between requests

3 participants

@rhamzeh @adriantam