chore: simplify ClientWriteStatus enum to basic Java enum

[curfew-marathon]

• Remove unnecessary value field, constructor, and getValue() method
• Update enum to use simple SUCCESS and FAILURE constants
• Update tests to expect uppercase enum names instead of lowercase values
• Follows standard Java enum practices and reduces complexity

Summary by CodeRabbit

• Refactor

  • Standardized client write status labels to uppercase (SUCCESS/FAILURE) across UI, logs, and responses; previously shown as lowercase.
  • This may affect automations or integrations that expect lowercase values.
  • No other behavior changes.

• Tests

  • Updated test coverage to reflect the uppercase status labels.

[coderabbitai]

Walkthrough

Converted ClientWriteStatus from a string-backed enum to a plain enum and updated corresponding tests to assert uppercase enum names via toString(), removing getValue() usage.

Changes

Cohort / File(s)	Summary
Java client write status enum and tests config/clients/java/template/src/main/api/client/model/ClientWriteStatus.java.mustache, config/clients/java/template/src/test/api/client/model/ClientWriteStatusTest.java.mustache	Enum changed from value-backed (with constructor, getValue(), toString() returning value) to plain enum (SUCCESS, FAILURE). Tests updated to remove getValue() assertions and expect toString() == "SUCCESS"/"FAILURE".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/simplify-client-write-status-enum

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

config/clients/java/template/src/test/api/client/model/ClientWriteStatusTest.java.mustache (2)

11-11: Prefer name() over toString() in assertions

toString() can be overridden; name() explicitly asserts the enum constant’s identifier. This makes the tests more robust without changing intent.

Apply this diff:

-        assertEquals("SUCCESS", ClientWriteStatus.SUCCESS.toString());
+        assertEquals("SUCCESS", ClientWriteStatus.SUCCESS.name());

---

16-16: Mirror the change for FAILURE test

Same reasoning as above; assert the enum identifier directly.

Apply this diff:

-        assertEquals("FAILURE", ClientWriteStatus.FAILURE.toString());
+        assertEquals("FAILURE", ClientWriteStatus.FAILURE.name());

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these settings in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7c39d23 and c7688c6.

📒 Files selected for processing (2)

• config/clients/java/template/src/main/api/client/model/ClientWriteStatus.java.mustache (1 hunks)
• config/clients/java/template/src/test/api/client/model/ClientWriteStatusTest.java.mustache (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: build-and-test-java-sdk
• GitHub Check: build-and-test-go-sdk
• GitHub Check: build-and-test-js-sdk

🔇 Additional comments (3)

config/clients/java/template/src/main/api/client/model/ClientWriteStatus.java.mustache (2)

4-7: Enum simplification LGTM

Switching to a plain enum with SUCCESS/FAILURE removes unnecessary boilerplate and aligns with idiomatic Java. No functional issues spotted in this template.

---

5-6: No serialization break detected — OK to keep bare enum

I ran the checks you requested. Short summary:

• No usages of ClientWriteStatus.getValue(...) or ClientWriteStatus.fromValue(...) found.
• No occurrences of lowercase "success"/"failure" in the Java client templates.
• The generated test asserts uppercase values: config/clients/java/template/src/test/api/client/model/ClientWriteStatusTest.java.mustache asserts "SUCCESS" and "FAILURE".
• There are generic enum templates that support @JsonValue/@JsonCreator (config/clients/java/template/libraries/native/modelEnum.mustache and modelInnerEnum.mustache), but that support does not appear to be applied to this enum.

Conclusion: the change to a bare enum producing "SUCCESS"/"FAILURE" appears intentional and not a breaking change in this repo. If external consumers expect lowercase wire values, add @JsonValue/@JsonCreator or a TypeAdapter; otherwise no fix required.

config/clients/java/template/src/test/api/client/model/ClientWriteStatusTest.java.mustache (1)

9-18: Tests updated correctly to reflect the simplified enum

The tests target the new uppercase identifiers and no longer depend on a value field or accessor. Once the minor nitpick above is addressed, this looks solid.