Skip to content

Conversation

@rhamzeh
Copy link
Member

@rhamzeh rhamzeh commented Apr 29, 2024

Description

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 83.01887% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 83.57%. Comparing base (c5b786f) to head (7d42e75).

Files Patch % Lines
client.ts 81.25% 4 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   83.94%   83.57%   -0.38%     
==========================================
  Files          18       18              
  Lines         922      968      +46     
  Branches      161      220      +59     
==========================================
+ Hits          774      809      +35     
- Misses         71       76       +5     
- Partials       77       83       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhamzeh rhamzeh changed the title feat(api): allow passing in storeId as a param feat: support list users Apr 30, 2024
@rhamzeh rhamzeh marked this pull request as ready for review April 30, 2024 01:00
@rhamzeh rhamzeh requested review from a team as code owners April 30, 2024 01:00
@rhamzeh rhamzeh added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit 9b4fe29 Apr 30, 2024
@rhamzeh rhamzeh deleted the feat/list-users branch April 30, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants