Skip to content

Use provided axios instance for credentials refresh operations #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Use provided axios instance for credentials refresh operations #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export class BaseAPI {
}
this.configuration.isValid();

this.credentials = Credentials.init(this.configuration);
this.credentials = Credentials.init(this.configuration, this.axios);

if (!this.axios) {
const httpAgent = new http.Agent({ keepAlive: true });
Expand Down
10 changes: 5 additions & 5 deletions credentials/credentials.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ export class Credentials {
private accessToken?: string;
private accessTokenExpiryDate?: Date;

public static init(configuration: { credentials: AuthCredentialsConfig, telemetry: TelemetryConfiguration, baseOptions?: any }): Credentials {
return new Credentials(configuration.credentials, globalAxios, configuration.telemetry, configuration.baseOptions);
}
public static init(configuration: { credentials: AuthCredentialsConfig, telemetry: TelemetryConfiguration, baseOptions?: any }, axios: AxiosInstance = globalAxios): Credentials {
return new Credentials(configuration.credentials, axios, configuration.telemetry, configuration.baseOptions);
}

public constructor(private authConfig: AuthCredentialsConfig, private axios: AxiosInstance = globalAxios, private telemetryConfig: TelemetryConfiguration, private baseOptions?: any) {
this.initConfig();
Expand Down Expand Up @@ -155,7 +155,7 @@ export class Credentials {
}, {
maxRetry: 3,
minWaitInMs: 100,
}, globalAxios);
}, this.axios);

const response = wrappedResponse?.response;
if (response) {
Expand All @@ -180,7 +180,7 @@ export class Credentials {

attributes = TelemetryAttributes.fromResponse({
response,
attributes,
attributes,
});

attributes = TelemetryAttributes.prepare(attributes, this.telemetryConfig.metrics?.counterCredentialsRequest?.attributes);
Expand Down
Loading