Skip to content

Conversation

@rhamzeh
Copy link
Member

@rhamzeh rhamzeh commented Mar 21, 2024

Description

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@rhamzeh rhamzeh force-pushed the feat/support-list-users branch from 5da7785 to 0f054a8 Compare March 21, 2024 01:21
@rhamzeh rhamzeh force-pushed the feat/support-list-users branch 4 times, most recently from 41aadc1 to 8fee642 Compare April 29, 2024 23:00
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 17.79279% with 730 lines in your changes are missing coverage. Please review.

Project coverage is 22.51%. Comparing base (d637093) to head (17c79da).

Files Patch % Lines
api_open_fga.go 23.39% 121 Missing and 10 partials ⚠️
model_list_users_request.go 13.11% 105 Missing and 1 partial ⚠️
model_unprocessable_content_message_response.go 0.00% 70 Missing ⚠️
model_object_or_userset.go 0.00% 66 Missing ⚠️
model_user.go 22.89% 60 Missing and 4 partials ⚠️
model_userset_user.go 14.08% 60 Missing and 1 partial ⚠️
model_user_type_filter.go 16.12% 51 Missing and 1 partial ⚠️
model_fga_object.go 15.51% 48 Missing and 1 partial ⚠️
model_list_users_response.go 15.51% 48 Missing and 1 partial ⚠️
model_unprocessable_content_error_code.go 0.00% 41 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   22.98%   22.51%   -0.48%     
==========================================
  Files          84       94      +10     
  Lines        8870     9758     +888     
==========================================
+ Hits         2039     2197     +158     
- Misses       6599     7308     +709     
- Partials      232      253      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	.github/workflows/main.yaml
#	.github/workflows/semgrep.yaml
@rhamzeh rhamzeh force-pushed the feat/support-list-users branch from 8fee642 to 2bb9966 Compare April 30, 2024 01:08
@rhamzeh rhamzeh marked this pull request as ready for review April 30, 2024 01:16
@rhamzeh rhamzeh requested review from a team as code owners April 30, 2024 01:16
@rhamzeh rhamzeh added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit d27ef8f Apr 30, 2024
@rhamzeh rhamzeh deleted the feat/support-list-users branch April 30, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants