fix: update continuation_token pattern restriction#216
Merged
Conversation
justincoh
changed the title
continuation_token pattern restriction
jpadilla
approved these changes
Dec 30, 2024
This was referenced Dec 30, 2024
aaguiarz
pushed a commit
that referenced
this pull request
Jan 13, 2026
* chore: remove lingering comment in proto defn * fix regex pattern to allow empty continuation token
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #215 we introduced a patten restriction on
continuation_tokenvalues. That pattern is correct if the value is present, but it did not account for requests where the token is not present.This PR updates the pattern to allow for empty strings also. I've tested locally on
openfgawith the updates here and it looks good.References
Review Checklist
main