Issue #153 - Add Gradle Wrapper scripts#154
Issue #153 - Add Gradle Wrapper scripts#154agasser wants to merge 1 commit intoopenfaas:masterfrom agasser:gradle-wrapper-scripts
Conversation
Signed-off-by: Andy Gasser <agasser01@hotmail.com>
| @@ -0,0 +1,188 @@ | |||
| #!/usr/bin/env sh | |||
There was a problem hiding this comment.
Do these files need to be duplicated in both locations?
There was a problem hiding this comment.
There already are wrapper folders in all of the sub-modules, but they won't work without the corresponding files. I suppose a better solution might be to delete those and not add the new files to the sub-modules. Does that sound better?
There was a problem hiding this comment.
I was about to write the same issue.
It would be handy to have the gradle wrapper in the handler module.
If it's not needed I would remove the wrapper folders from the other modules.
|
Hi, thanks for your patch. I noticed that there's a lot of duplication. Can you elaborate on why the files are needed in each folder? Alex |
|
Closing in favour of newer PR. |
Add missing Gradle Wrapper scripts
Description
The Gradle Wrapper includes scripts for executing Gradle on Windows and *nix. These scripts need to be included in source control. This PR adds them to address issue #153 .
Motivation and Context
Which issue(s) this PR fixes
Fixes #153
How Has This Been Tested?
At the root of the java8 template project, I ran the gradle build on OSX using the command
./gradlew build.Types of changes
Checklist:
git commit -s