Skip to content

Issue #153 - Add Gradle Wrapper scripts#154

Closed
agasser wants to merge 1 commit intoopenfaas:masterfrom
agasser:gradle-wrapper-scripts
Closed

Issue #153 - Add Gradle Wrapper scripts#154
agasser wants to merge 1 commit intoopenfaas:masterfrom
agasser:gradle-wrapper-scripts

Conversation

@agasser
Copy link
Copy Markdown

@agasser agasser commented Jun 5, 2019

Add missing Gradle Wrapper scripts

Description

The Gradle Wrapper includes scripts for executing Gradle on Windows and *nix. These scripts need to be included in source control. This PR adds them to address issue #153 .

Motivation and Context

Which issue(s) this PR fixes

Fixes #153

How Has This Been Tested?

At the root of the java8 template project, I ran the gradle build on OSX using the command ./gradlew build.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@derek derek bot added the new-contributor label Jun 5, 2019
Signed-off-by: Andy Gasser <agasser01@hotmail.com>
@@ -0,0 +1,188 @@
#!/usr/bin/env sh
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these files need to be duplicated in both locations?

Copy link
Copy Markdown
Author

@agasser agasser Jul 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There already are wrapper folders in all of the sub-modules, but they won't work without the corresponding files. I suppose a better solution might be to delete those and not add the new files to the sub-modules. Does that sound better?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to write the same issue.
It would be handy to have the gradle wrapper in the handler module.
If it's not needed I would remove the wrapper folders from the other modules.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexellis what do you think?

@alexellis
Copy link
Copy Markdown
Member

Hi, thanks for your patch.

I noticed that there's a lot of duplication. Can you elaborate on why the files are needed in each folder?

Alex

@alexellis
Copy link
Copy Markdown
Member

Closing in favour of newer PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Gradle Wrapper script files from java8 template

3 participants