Implemented ServiceLoader in Entrypoint

[kameshchauhan]

Description

Motivation and Context

• I have raised an issue to propose this change (required)

Which issue(s) this PR fixes

Fixes #

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Version change (see: Impact to existing users)

Impact to existing users

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have signed-off my commits with git commit -s
• I have added tests to cover my changes.
• All new and existing tests passed.

[ieugen]

Thanks for contributing this @kameshchauhan .
I'll pester @alexellis so we get this merged 😁 .

I've also worked on #3 .
It's done (need to test publish and sign).

Could you do a review please?

[alexellis]

Thank you for your contributions. I think we already have this covered though. Can you take a look at yesterday's commits?

[ieugen]

I believe this should be on the test resources and not on main.

[ieugen]

The PR adds tests for service loader.
It does not change the code that exists.

[alexellis]

We already have the ServiceLoader see: https://github.com/openfaas/templates-sdk/tree/master/java11/entrypoint/src/main/java/com/openfaas/entrypoint and https://github.com/openfaas/templates-sdk/tree/master/java11/entrypoint/src/main/resources/META-INF/services

[alexellis]

Given that this PR is trying to do something we have now, we should probably close it, unless there's something else we want from it in a new PR?

[ieugen]

@alexellis , Please see the diff. The PR adds a test for the service loader functionality.
It does not change the code.
I've mentioned this in my previous commend.

[alexellis]

This can't be merged until the commits are cleaned up, currently there are around 15 which are rather messy but also include unnecessary merge commits. Starting a new branch may be easiest, or running git reset or git rebase. Plenty of info online for how to do this.

The title of the PR would also need to be updated as per the commit i.e. "add a test for the service loader".

[alexellis]

Please see the comments