feat: update python to 3.11 and add build-arg #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the default python 3 version to 3.11. Additionally, add a build arg for PYTHON_VERSION and WATCHDOG_VERSION so make it easy for developers to pin the python version that they need for their project. The docs are updated with instructions about pinning the python version. Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
This was referenced Apr 23, 2023
Member
|
Looks really good, could we drop |
Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
Member
Author
|
done |
alexellis
approved these changes
May 10, 2023
Member
alexellis
left a comment
alexellis
left a comment
There was a problem hiding this comment.
LGTM. Thank you for amending the README too 👍
Perhaps we need a similar example or a note at https://docs.openfaas.com/cli/templates/#python-3-templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the default python 3 version to 3.11. Additionally, add a build arg for PYTHON_VERSION and WATCHDOG_VERSION so make it easy for developers to pin the python version that they need for their project.
The docs are updated with instructions about pinning the python version.
Motivation and Context
design/approvedlabelWe were discussing this during a Community Call in the context of AWS lambda and their slow upgrade cycle for python. We realized we also needed to update our templates.
How Has This Been Tested?
This was manually tested and working with the default "echo" function for each template.
Types of changes
Checklist:
git commit -s