Skip to content

Conversation

amalkh5
Copy link
Contributor

@amalkh5 amalkh5 commented May 12, 2020

This PR will add badges to README.md

Signed-off-by: Amal Alkhamees amalkms5@gmail.com

Description

Motivation and Context

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Amal Alkhamees <amalkms5@gmail.com>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis merged commit 8e9eefd into openfaas:master May 12, 2020
@alexellis
Copy link
Member

Thank you Amal :)

@amalkh5 amalkh5 deleted the add-badges branch May 12, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants