Skip to content

Conversation

matthiashanel
Copy link
Contributor

@matthiashanel matthiashanel commented May 1, 2020

Description

Fixes #96

Adding max_inflight and removing faas_nats_durable_queue_subscription.
Making sure 0 does not make it to streaming by setting it to 1.

Motivation and Context

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

Compiles

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Fixes openfaas#96

Adding max_inflight and removing faas_nats_durable_queue_subscription.
Making sure 0 does not make it to streaming by setting it to 1.

Signed-off-by: Matthias Hanel <mh@synadia.com>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis merged commit a3250e1 into openfaas:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove durable config from the readme

2 participants