Skip to content

Conversation

ewilde
Copy link
Contributor

@ewilde ewilde commented Dec 10, 2019

Description

Adds original function name in callback meta-data X-Function-Name

Motivation and Context

How Has This Been Tested?

Tested on docker swarm:

  • Invoke function a (in this example called echo) asynchronously provide callback to function b
  • verify header is set

Logs for function b

2019-12-10T21:17:05Z 2019/12/10 21:17:05 stderr: 2019/12/10 21:17:05 Function: [echo], status:[200], time:[0.001863], body:OK

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly see: X-Function-Name meta-data added to async section docs#195.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@LucasRoesler LucasRoesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and it works as described 👍

@alexellis
Copy link
Member

This branch has conflicts that must be resolved.
Use the command line to resolve conflicts before continuing

👨‍💻

@alexellis
Copy link
Member

@ewilde please see my comment.

Adds original function name in callback meta-data `X-Function-Name`

Resolves openfaas#82

Signed-off-by: Edward Wilde <ewilde@gmail.com>
@ewilde ewilde force-pushed the ew/x-function-name branch from 6a4dc07 to 95bad39 Compare December 15, 2019 22:40
@ewilde
Copy link
Contributor Author

ewilde commented Dec 15, 2019

@alexellis PTAL, rebased

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis merged commit ca46476 into openfaas:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants