Fix for issue #73 #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feel free to test out |
|
cc @acornies @jonatasbaldin please take a look at the changes mostly from @bmcstdio with some additional missing error handling (which may be historical). I'm curious why we didn't run into this earlier, perhaps the image wasn't updated since we accepted the changes? |
bmcustodio
suggested changes
Nov 25, 2019
main.go
Outdated
|
|
||
| natsQueue := NATSQueue{ | ||
| clusterID: config.NatsClusterName, | ||
| clusterID: "faas-cluster", |
Due to an issue described in #73 by @bmcstdio the error handling has been improved to prevent nil pointer dereference errors in several scenarios. Improves error messages for queue-worker output. Tested with and without gateway_invoke by changing the gateway port to an invalid one and the gateway address to an invalid one. Closes: #73 Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
alexellis
force-pushed
the
openfaasltd/fix-gateway-invoke
branch
from
becc587 to
9470845
Compare
|
Squashed / rebased. Latest image is: Anyone affected by this can revert to an earlier version of the queue-worker. Before #67 was merged or try the pre-release image from above. |
|
@alexellis |
|
Thanks Bruno. I'll kick off a release, can you update helm please? |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue found in #73 via @bmcstdio
How Has This Been Tested?
faas_gateway_addresssuch asgateway.openfaas.svc.cluster.local:9090- at runtime:8080will be appended and this will now fail to post but not cause a panicfaas_gateway_portand the code will panic on start-up and log out the errorTypes of changes
Checklist:
git commit -s