Skip to content

Conversation

@LucasRoesler
Copy link
Member

Description

  • Update to the latest of-watchdog 0.7.7, ensuring the request context
    is propagated correctly
  • Add examples of how to use the context to abort requests early

Resolve #40

How Has This Been Tested?

I manually tested this with the example from the issue #40 (comment)

image

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests

**What**
- Update to the latest of-watchdog 0.7.7, ensureing the request context
  is propagated correctly
- Add examples of how to use the context to abort requests early

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@alexellis alexellis merged commit 689ef46 into openfaas:master Apr 5, 2020
@alexellis
Copy link
Member

Lgtm thank you

@LucasRoesler LucasRoesler deleted the udpate-of-watchdog-and-docs branch April 6, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

golang-http does not allow graceful request cancelling

2 participants