Support request debug logging in the builder package #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The request body is only logged if the Content-Type is printable (e.g. application/json or text/plain) to prevent payloads that are not human readable, like the build context tar, from getting logged out. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support setting
FAAS_DEBUG=1for request made to the Function Builder API using the go-sdk.The request body is only logged if the Content-Type is printable (e.g. application/json or text/plain) to prevent payloads that are not human readable, like the build context tar, from getting logged out.
How has this been tested
Unit test have been updated and this change has been tested by using this version of the go-sdk with the faas-cli.
Verified requests are printed to the console correctly when the
FAAS_DEBUG=1env variable is set.